Skip to content

feat(pkg-py): Add .app() method, enable bookmarking by default #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(pkg-py): Add .app() method, enable bookmarking by default #104

wants to merge 5 commits into from
+220 −27

Conversation

@cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Nov 14, 2025 •
edited
Loading

Closes #69

@cpsievert cpsievert mentioned this pull request Nov 14, 2025
Closed
2 tasks
cpsievert
cpsievert commented Nov 15, 2025
View reviewed changes
pyproject.toml Outdated
"duckdb",
"pandas",
"shiny",
"shiny @ git+https://github.com/posit-dev/py-shiny.git",
Copy link
Contributor Author

@cpsievert cpsievert Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would require a release

Suggested change
"shiny @ git+https://github.com/posit-dev/py-shiny.git",
"shiny>1.5.0",

Copy link
Contributor

@gadenbuie gadenbuie Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this PR related to or impacted by posit-dev/py-shiny#2117?

Copy link
Contributor Author

@cpsievert cpsievert Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that fix, when a bookmark occurs, you get an error notification about it failing

Copy link
Contributor Author

@cpsievert cpsievert Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I had overlooked that enabling by default isn't a good idea since if you enable without a store in place you get an error.

19515d9 changes things to only enable if a store is set, so I think it's probably fine to not add the shiny version requirement (17df2c7)

Base automatically changed from feat/py-new-api to main November 18, 2025 22:27
@cpsievert cpsievert force-pushed the feat/py-app-method branch 5 times, most recently from 60e9b32 to 8e699a5 Compare November 18, 2025 22:47
@cpsievert cpsievert requested a review from Copilot November 18, 2025 22:53
@cpsievert cpsievert marked this pull request as ready for review November 18, 2025 22:54

This comment was marked as resolved.

Sign in to view

@cpsievert cpsievert requested a review from gadenbuie November 18, 2025 22:57
gadenbuie
gadenbuie reviewed Nov 19, 2025
View reviewed changes
@cpsievert cpsievert requested a review from gadenbuie November 20, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gadenbuie gadenbuie Awaiting requested review from gadenbuie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Add querychat.app() function

3 participants

@cpsievert @gadenbuie